Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving docker-dcm to this repo #39

Open
pdurbin opened this issue Mar 17, 2023 · 1 comment
Open

Moving docker-dcm to this repo #39

pdurbin opened this issue Mar 17, 2023 · 1 comment

Comments

@pdurbin
Copy link
Collaborator

pdurbin commented Mar 17, 2023

@poikilotherm and I were just discussing the future of docker-aio in the context of a new containerization effort we are kicking off next week. (All are welcome!)

Thanks to @poikilotherm we've made some excellent progress recently in creating a Dataverse container for dev purposes, to the point that we're considering removing docker-aio from the code base.

However, I'm aware that docker-dcm and its docker-compose file rely on docker-aio. Would it be possible to copy the docker-dcm files (and the docker-aio, files if they are desired) into this repo? Perhaps someone will find them useful some day. Alternatively, we could simply delete them. They'll be in the git history! 😅

On a related note, we are discussing the deprecation of the rsync feature in Dataverse here:

Please let us know what you think. Thanks! ❤️

@pameyer
Copy link
Member

pameyer commented Mar 17, 2023

@pdurbin Glad to hear the new containerization effort is making good progress!

If you think it's worth copying them here, feel free to make a PR. But I think your idea about deleting, and going to git history if necessary, may be the way to go. The main point of docker-dcm was "dataverse configured for a DCM/RSAL"; bringing it in to this repo might have a bunch of "dangling references" to the dataverse repo. I'd also guess there have been changes in how to configure dataverse that docker-dcm / DCM/RSAL in general haven't kept up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants