Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: New PQueue is created on every operation #104

Closed
1 of 2 tasks
kadisonm opened this issue Jan 11, 2024 · 3 comments · Fixed by #106
Closed
1 of 2 tasks

[Bug]: New PQueue is created on every operation #104

kadisonm opened this issue Jan 11, 2024 · 3 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@kadisonm
Copy link

kadisonm commented Jan 11, 2024

What happened?

A new PQueue is created on every operation (folder creation, delete, upload) causing the status bar to show 3 seperate queues.

Accumilate all the files needed for upload on a single queue. I'll do some testing on this.

What OS are you using?

Windows

What remote cloud services are you using?

Dropbox

Version of the plugin

No response

Version of Obsidian

No response

Using password or not

  • Yes.

Ensure no sensitive information

  • I ensure that no sensitive information is submitted in the issue.
@kadisonm kadisonm added the bug Something isn't working label Jan 11, 2024
@kadisonm
Copy link
Author

Actually now that I'm thinking about it, shouldn't the status bar only be updated for upload/downloads? @sboesen

@kadisonm kadisonm moved this to In progress in Remotely Sync Jan 12, 2024
@sboesen
Copy link
Owner

sboesen commented Jan 12, 2024

I think if you have a lot of folder creations (usually a one-time problem) that should be tracked in the status bar, too - I don't think this is a bulk operation

But there shouldn't be a queue created for each operation. That is odd..

@kadisonm
Copy link
Author

But there shouldn't be a queue created for each operation. That is odd..

It's because it loops through each array (operation), then creates a queue for that array and adds uploads to the queue. But this causes the status bar to show three queues in order.

I think if you have a lot of folder creations (usually a one-time problem) that should be tracked in the status bar

I'll have a look at updating the status bar for folder creations and upload/downloads but not deletions.

@github-project-automation github-project-automation bot moved this from In progress to Done in Remotely Sync Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants