Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Impossible to prevent deleted files from being deleted #61

Closed
1 of 2 tasks
sboesen opened this issue Dec 7, 2023 · 4 comments
Closed
1 of 2 tasks

[Bug]: Impossible to prevent deleted files from being deleted #61

sboesen opened this issue Dec 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@sboesen
Copy link
Owner

sboesen commented Dec 7, 2023

What happened?

From #60 / @Engineer-Extreme:

Possible Issue 3:
I tried to circumvent Possible Issue 1 by pasting the local vault with correct creation and modification times to OneDrive manually (which uploads correct modification times on the remote), but then when I tried to Remotely Sync, it somehow assumed that all the files were deleted in the cloud and hence deleted my entire local vault. I did a DB reset before testing every issue I identified above.

Possible Issue 4:
Which brings me to another issue regarding the database which stores metadata. Because my entire local vault was deleted, and that was the state of Remotely Sync even after multiple retries, I decided to reinstall the plugin, authenticate from scratch so that it would at least not keep that delete state for every file. I also deleted the remote "Apps/Remotely Secure" folder on OneDrive. But unfortunately, I don't know how but the "deletion state" still exists and Remotely Sync still assumes the files were all deleted in local. And this after reinstalling in the same vault without restoring those deleted files. Somehow Remotely Sync still has the listing of all of the original files even though there is nothing in the vault and I reset Remotely Sync. It should start with an empty file list with no history from before the reinstall, but it has the history of all of the files in the vault which actually don't exist anymore!

What OS are you using?

Windows, Linux, macOS, iOS (iPhone, iPad), Android

What remote cloud services are you using?

S3, OneDrive for personal, Dropbox, webdav

Version of the plugin

No response

Version of Obsidian

No response

Using password or not

  • Yes.

Ensure no sensitive information

  • I ensure that no sensitive information is submitted in the issue.
@sboesen sboesen added the bug Something isn't working label Dec 7, 2023
@sboesen sboesen changed the title [Bug]: Issue stopping deleted files from being deleted [Bug]: Impossible to prevent deleted files from being deleted Dec 7, 2023
@sboesen
Copy link
Owner Author

sboesen commented Dec 7, 2023

Deletion tracking is not in a great state right now. Initial thoughts are a workaround to clear both local & remote deletion history with a button & tons of warnings.

@sboesen
Copy link
Owner Author

sboesen commented Dec 16, 2023

Added in #58. Please give this a try - will open a new feature request for improving deleted items tracking (#75)

@sboesen sboesen closed this as completed Dec 16, 2023
@kadisonm
Copy link

kadisonm commented Jan 7, 2024

When I uninstall and reinstall I find the local DB isn't deleted. Is this intended?

@sboesen
Copy link
Owner Author

sboesen commented Jan 8, 2024

🤔 Not sure. I assumed it was stored in the plugin folder but maybe not? Haven't looked into the local db much. Probably worth adding a new issue for this, sounds like a problem

@kadisonm kadisonm moved this to Done in Remotely Sync Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants