Add support for detecting previous stable version #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for never giving any feedback on this. Where does this PR stand currently? Are you still interested in this change? Given the merge conflicts, have the changes in master impacted this PR? I've been feeling the mild itch that this feature should really exist in sbt-dynver, so I'm interested in trying to land it. Alternatively my OCD is eager to close this PR if it's abandoned. 😄 |
|
The conflicts seems minor. I'll fix this up |
|
Thank you! |
|
I'm working on more test cases and will also add documentation |
|
This is ready for review :) |
This command returns the last stable tagged version before the current HEAD. If a tag cannot be found for any reason (no parent commit or no tag) then the result is None.
dwijnand
approved these changes
Jun 7, 2018
|
This is awesome. Thank you @jatcwang and @MaxwellBo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command always return the last tagged version before the current HEAD.
Most of the work was done by @MaxwellBo. I just fixed some issues found in usage and cleaned it up slightly.
NOTE
When I run
^ mimaReportBinaryIssuesit seems to only run the task for the current SBT version. Manually switching SBT cross build version using^^ 1.0.4thenmimaReportBinaryIssuesworks fine. Maybe you can spot what I'm doing wrong but this is what I've done for other SBT plugins and it seems to work fine there