-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare sbt-github-actions for release under sbt org #132
Comments
You mean release under I am generally neutral about whether a plugin should publish under |
I guess? I mean whatever org sbt software is typically published under. Not sure if this is maven/sonatype sbt org or another like the github one you mentioned. I will trust your best judgment, for me personally just want to get the release process working. |
As a side note, if you decide to publish under a new organization, please let Scala Steward know about that change. |
Will do, thanks for the heads up! |
@eed3si9n Sorry to ping you but because of https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ (which was resolved in #133) we should probably look into making a release sooner rather than later. If you don't have time can you point me to a sample sbt project as a reference and/or add in the relevant secrets to this repo and I can have a look into doing this. |
Here's my PR for setting up sbt-ci-release - #134 |
Two problems:
First is that it's using JDK 11, and the second is the ++ 2.12.17 thing. |
@fthomas PR created at scala-steward-org/scala-steward#2914 |
@eed3si9n Regarding JDK version, this can be changed by updating https://github.com/sbt/sbt-github-actions/blob/main/build.sbt#L25. I can setup a PR, what JDK version should we be using? I noticed that its set to use GraalVM/JDK 11, I suppose using standard JVM JDK 17 is best bet to be safe? |
PR for updating to JDK 17 made at #136 |
So the above PR is passing and ready, I am not sure if upgrading to JDK 17 will fix the problem but nonetheless its the latest stable version so it should have been updated anyways. Once #136 is merged I will also do another PR that will update the default Scala version to the latest as well |
Snapshot publishing worked - https://oss.sonatype.org/content/repositories/snapshots/com/github/sbt/sbt-github-actions_2.12_1.0/0.14.2-SNAPSHOT/ Now all you need is push a tag to make actual publish. |
Perfect, thanks for pushing this. I will make a PR tomorrow to update Scala version and then I will trigger a release |
We should look into preparing/testing sbt-github-actions so it can be released under the sbt org. A few people (including myself) are waiting for this feature #105 so this is a good testing bed to make the first sbt org release of this project.
@eed3si9n Thoughts?
The text was updated successfully, but these errors were encountered: