Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare sbt-github-actions for release under sbt org #132

Closed
mdedetrich opened this issue Jan 4, 2023 · 13 comments · Fixed by #134 or #137
Closed

Prepare sbt-github-actions for release under sbt org #132

mdedetrich opened this issue Jan 4, 2023 · 13 comments · Fixed by #134 or #137

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 4, 2023

We should look into preparing/testing sbt-github-actions so it can be released under the sbt org. A few people (including myself) are waiting for this feature #105 so this is a good testing bed to make the first sbt org release of this project.

@eed3si9n Thoughts?

@eed3si9n
Copy link
Member

eed3si9n commented Jan 5, 2023

You mean release under com.github.sbt?

I am generally neutral about whether a plugin should publish under com.github.sbt or some other organization name.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Jan 5, 2023

You mean release under com.github.sbt?

I guess?

I mean whatever org sbt software is typically published under. Not sure if this is maven/sonatype sbt org or another like the github one you mentioned. I will trust your best judgment, for me personally just want to get the release process working.

@fthomas
Copy link
Contributor

fthomas commented Jan 5, 2023

As a side note, if you decide to publish under a new organization, please let Scala Steward know about that change.

@mdedetrich
Copy link
Contributor Author

Will do, thanks for the heads up!

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Jan 11, 2023

@eed3si9n Sorry to ping you but because of https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ (which was resolved in #133) we should probably look into making a release sooner rather than later.

If you don't have time can you point me to a sample sbt project as a reference and/or add in the relevant secrets to this repo and I can have a look into doing this.

@eed3si9n
Copy link
Member

Here's my PR for setting up sbt-ci-release - #134

@eed3si9n
Copy link
Member

eed3si9n commented Jan 12, 2023

Two problems:

[info] welcome to sbt 1.8.2 (Eclipse Adoptium Java 11.0.17)
[info] loading settings for project sbtGithubActionsSources from build.sbt,libraries.sbt ...
[info] loading project definition from /home/runner/work/sbt-github-actions/sbt-github-actions/project/project
[info] compiling [16](https://github.com/sbt/sbt-github-actions/actions/runs/3900050793/jobs/6660371077#step:8:17) Scala sources to /home/runner/work/sbt-github-actions/sbt-github-actions/project/project/target/scala-2.12/sbt-1.0/classes ...
[warn] one feature warning; re-run with -feature for details
[warn] one warning found
[info] done compiling
[info] loading settings for project sbt-github-actions-build from libraries.sbt,plugins.sbt ...
[info] loading project definition from /home/runner/work/sbt-github-actions/sbt-github-actions/project
[info] loading settings for project sbt-github-actions from build.sbt,libraries.sbt ...
[info] looking for workflow definition in /home/runner/work/sbt-github-actions/sbt-github-actions/.github/workflows
[info] set current project to sbt-github-actions (in build file:/home/runner/work/sbt-github-actions/sbt-github-actions/)
[error] Switch failed: no subprojects list "2.12.[17](https://github.com/sbt/sbt-github-actions/actions/runs/3900050793/jobs/6660371077#step:8:18)" (or compatible version) in crossScalaVersions setting.
[error] If you want to force it regardless, call ++ 2.12.17!

Error: Process completed with exit code 1.

First is that it's using JDK 11, and the second is the ++ 2.12.17 thing.

@mdedetrich
Copy link
Contributor Author

@fthomas PR created at scala-steward-org/scala-steward#2914

@mdedetrich
Copy link
Contributor Author

@eed3si9n Regarding JDK version, this can be changed by updating https://github.com/sbt/sbt-github-actions/blob/main/build.sbt#L25. I can setup a PR, what JDK version should we be using? I noticed that its set to use GraalVM/JDK 11, I suppose using standard JVM JDK 17 is best bet to be safe?

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Jan 12, 2023

PR for updating to JDK 17 made at #136

@mdedetrich
Copy link
Contributor Author

So the above PR is passing and ready, I am not sure if upgrading to JDK 17 will fix the problem but nonetheless its the latest stable version so it should have been updated anyways. Once #136 is merged I will also do another PR that will update the default Scala version to the latest as well

@eed3si9n
Copy link
Member

Snapshot publishing worked - https://oss.sonatype.org/content/repositories/snapshots/com/github/sbt/sbt-github-actions_2.12_1.0/0.14.2-SNAPSHOT/

Now all you need is push a tag to make actual publish.

@mdedetrich
Copy link
Contributor Author

Perfect, thanks for pushing this. I will make a PR tomorrow to update Scala version and then I will trigger a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants