Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish sbt-scalafix for 2.13 #982

Closed
benwaffle opened this issue Sep 7, 2019 · 13 comments · Fixed by #999
Closed

Publish sbt-scalafix for 2.13 #982

benwaffle opened this issue Sep 7, 2019 · 13 comments · Fixed by #999

Comments

@benwaffle
Copy link

No description provided.

@olafurpg
Copy link
Contributor

Thank you for reporting! sbt-scalafix is published for sbt v1, which only compiles on 2.12. Do you mean scalafix-core for 2.13?

@UkonnRa
Copy link

UkonnRa commented Sep 19, 2019

+1, now Scala 2.13.1 is release, I think maybe it's time to publish the scalafix for Scala 2.13?

@benwaffle
Copy link
Author

sbt works with 2.13 as well

@ironfish
Copy link

ironfish commented Oct 7, 2019

Any update on this as to when it will be released for Scala 2.13??

@olafurpg
Copy link
Contributor

olafurpg commented Oct 8, 2019

Scalafix should work with Scala 2.13 since a while ago. Can you please elaborate on what this issue is about?

@Slakah
Copy link

Slakah commented Nov 5, 2019

@olafurpg , the documentation suggests that only 2.11 and 2.12 are supported. Happy to open a PR to update the site!

Screenshot 2019-11-05 at 13 00 14

@steinybot
Copy link

There are a few other things in the documentation which need updating for Scala 2.13.

The NoAutoTupling rule doesn't work since -Ywarn-adapted-args has been removed as part of scala/scala-dev#496 (scala/scala#6505). There is an ongoing discussion about this in scala/bug#11110.

A new section is needed in the RemoveUnused rule as the warnings have been partitioned from verbose options. -Ywarn-unused-imports is now -Wunused:imports.

@steinybot
Copy link

steinybot commented Nov 27, 2019

The sbt plugin complains if you don't have -Ywarn-unused:

[error] (Compile / scalafix) scalafix.sbt.InvalidArgument: The Scala compiler option "-Ywarn-unused" is required to use RemoveUnused.
[error] To fix this problem, update your build to use at least one Scala compiler
[error] option that starts with "-Ywarn-unused"
[error] Total time: 2 s, completed 28/11/2019 11:24:05 AM

@olafurpg
Copy link
Contributor

@steinybot thank you! Good catch. I opened #999 improving the docs and support for 2.13

@benwaffle
Copy link
Author

@olafurpg I don't see sbt-scalafix for 2.13 here:

https://repo1.maven.org/maven2/ch/epfl/scala/

I would expect it to be at this url:

https://repo1.maven.org/maven2/ch/epfl/scala/sbt-scalafix_2.13_1.0/

@benwaffle
Copy link
Author

this is kind of difficult - need to release https://github.com/olafurpg/coursier-small for 2.13, which depends on a coursier-cache 1.1.x release for 2.13

i think sbt 2.12 plugins might still work on 2.13 projects...need to investigate

@olafurpg
Copy link
Contributor

olafurpg commented Jan 6, 2020

@benwaffle can you please describe what problems you’re encountering with 2.13? Sbt plugins only compile against 2.12.

@olafurpg olafurpg reopened this Jan 6, 2020
@benwaffle
Copy link
Author

you're right

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants