Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JSON-RPC read/write loop to use monix #152

Closed
olafurpg opened this issue Dec 22, 2017 · 1 comment
Closed

Refactor JSON-RPC read/write loop to use monix #152

olafurpg opened this issue Dec 22, 2017 · 1 comment
Labels
tech debt We should have addressed this yesterday

Comments

@olafurpg
Copy link
Member

Currently, Connection is a big while loop reading/writing json back and forth. This has worked nicely so far but while implementing textDocument/codeActions I found myself needing to send a workspace/applyEdit request from the server to the client. This was not that hard to implement in the end, but it took me a while to figure out what I needed to do.

It would be nice to refactor the code a bit to use requests: Observable[JsValue] and expose a client: LanguageClient where we can do methods like client.workspace.applyEdit(): Task[ApplyWorkspaceEditResponse].
@olafurpg olafurpg added the tech debt We should have addressed this yesterday label Dec 22, 2017
@olafurpg
Copy link
Member Author

olafurpg commented Jan 6, 2018

Fixed in #164

@olafurpg olafurpg closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt We should have addressed this yesterday
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olafurpg