Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server respect configuration #161

Closed
4 tasks done
gabro opened this issue Dec 30, 2017 · 3 comments
Closed
4 tasks done

Make server respect configuration #161

gabro opened this issue Dec 30, 2017 · 3 comments
Labels
configuration Tickets related to user configuration
Milestone
0.1.0 - Copper

Comments

@gabro
Copy link
Member

gabro commented Dec 30, 2017 •
edited by olafurpg
Loading

#158 added a comprehensive configuration, but not all settings are respected by the server.

Namely:

  • Hover/enabled
  • Scalac/enableCompletions
  • Scalafix/confPath
  • index JDK on indexJDK=true
@gabro gabro added the configuration Tickets related to user configuration label Dec 30, 2017
@gabro gabro mentioned this issue Dec 30, 2017
Merged
2 tasks
@olafurpg olafurpg added this to the 0.1.0 milestone Jan 3, 2018
@olafurpg
Copy link
Member

olafurpg commented Jan 3, 2018

I added this to the v0.1 milestone, since completion is still enabled by default even if scalameta.scalac.enabled=false by default.

@olafurpg olafurpg mentioned this issue Jan 3, 2018
Merged
@laughedelic laughedelic mentioned this issue Feb 16, 2018
Merged
3 tasks
@gabro gabro mentioned this issue Feb 22, 2018
Merged
@laughedelic laughedelic mentioned this issue Mar 12, 2018
Merged
@olafurpg
Copy link
Member

olafurpg commented Apr 1, 2018

Can we close this ticket now?

@gabro
Copy link
Member Author

gabro commented Apr 1, 2018

Yep!

@gabro gabro closed this as completed Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
configuration Tickets related to user configuration
Projects
None yet
Milestone
0.1.0 - Copper
Development

No branches or pull requests
2 participants
@gabro @olafurpg