Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fine-grained leveldb locks #49

Closed
olafurpg opened this issue Nov 22, 2017 · 1 comment
Closed

More fine-grained leveldb locks #49

olafurpg opened this issue Nov 22, 2017 · 1 comment
Labels
tech debt We should have addressed this yesterday

Comments

@olafurpg
Copy link
Member

In #45 we currently lock the global cache during the entire period of indexing a classpath. We should explore ways to minimize locking as much as possible, and also improve error handling (e.g., by retry) when the lock is taken.
@olafurpg olafurpg mentioned this issue Nov 22, 2017
Merged
@gabro gabro added the tech debt We should have addressed this yesterday label Dec 1, 2017
@olafurpg
Copy link
Member Author

Fixed in #332. Now that we can mtags index Scala sources at ~800k loc/s we no longer need persistent caching so leveldb has been removed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt We should have addressed this yesterday
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabro @olafurpg