sandbox-docker-compose broken by upstream changes #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik21
approved these changes
Nov 1, 2021
ratik21
pushed a commit
that referenced
this pull request
Dec 23, 2021
* /tmp no longer necessary, added to the upstream algorand/sandbox (#508) * Bump nokogiri from 1.11.2 to 1.12.5 in /docs Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.2 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.2...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Devin Kiser <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ratik21
pushed a commit
that referenced
this pull request
Dec 23, 2021
* /tmp no longer necessary, added to the upstream algorand/sandbox (#508) * Bump rexml from 3.2.4 to 3.2.5 in /docs Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.4...v3.2.5) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Devin Kiser <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ratik21
pushed a commit
that referenced
this pull request
Dec 23, 2021
* /tmp no longer necessary, added to the upstream algorand/sandbox (#508) * Bump addressable from 2.7.0 to 2.8.0 in /docs Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Devin Kiser <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to the latest Algod 3.x.x, Docker was unable to build a new algod image using the provided
make sandbox-up. After investigation I found that a recent change on algorand/sandbox c3fa3acce89747b8a864ceb32890cca22a319b4d broke compatibility with algo-builder's provided scripts. This pull request will resolve the issue by removing the no longer necessary/tmpportion of the 'TEMPLATE' variable's pathProposed Changes
Potential followups