Fixbug int opcode can't start with 0x #562

vuvoth · 2022-01-26T15:18:19Z

Proposed Changes

Support prefix 0x(hex) and 0(oct) for Int opcode
Add assertNumber for assert data is number with 3 format dec, oct, hex.
Unit tests.

robert-zaremba

pre-approving

packages/runtime/src/lib/constants.ts

packages/runtime/src/lib/parsing.ts

packages/runtime/test/src/parser/parsing.ts

ratik21

We need changelog update

packages/runtime/src/lib/parsing.ts

vuvoth added 2 commits January 26, 2022 21:58

fixbug Int Pseudo-Ops can't start with 0x(hex) or 0(oct) prefix

29c4c05

fix bug when number = 0 on int opcode

dc54429

vuvoth requested review from robert-zaremba, ratik21 and surbhit14 January 26, 2022 15:18

robert-zaremba approved these changes Jan 26, 2022

View reviewed changes

packages/runtime/src/lib/constants.ts Outdated Show resolved Hide resolved

packages/runtime/src/lib/parsing.ts Show resolved Hide resolved

packages/runtime/test/src/parser/parsing.ts Outdated Show resolved Hide resolved

fix early review

7c61d0e

vuvoth requested a review from robert-zaremba January 26, 2022 17:36

Merge branch 'develop' into fixbug-int-opcode-can't-start-with-0x

26b0601

ratik21 reviewed Jan 27, 2022

View reviewed changes

packages/runtime/src/lib/parsing.ts Outdated Show resolved Hide resolved

update CHANGELOG.md

add0c9f

vuvoth merged commit cb945de into develop Jan 27, 2022

vuvoth deleted the fixbug-int-opcode-can't-start-with-0x branch January 27, 2022 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixbug int opcode can't start with 0x #562

Fixbug int opcode can't start with 0x #562

vuvoth commented Jan 26, 2022

robert-zaremba left a comment

ratik21 left a comment

Fixbug int opcode can't start with 0x #562

Fixbug int opcode can't start with 0x #562

Conversation

vuvoth commented Jan 26, 2022

Proposed Changes

robert-zaremba left a comment

Choose a reason for hiding this comment

ratik21 left a comment

Choose a reason for hiding this comment