Fixbug from address is alway application address when use inner Tx. #569

vuvoth · 2022-02-01T13:24:21Z

Proposed Changes

Fix bug sender is always application address in inner tx.
Test for this case(rekey-inner-tx.ts)

packages/runtime/src/lib/itxn.ts

packages/runtime/test/integration/rekey-inner-tx.ts

ratik21

Please add TODO, and update changelog before merging

vuvoth added 3 commits January 23, 2022 18:40

testcase when rekey account to contract

328f988

Merge branch 'develop' into test-and-fixbug-rekey-and-itxn

f496c47

fix typo

9357075

vuvoth requested review from robert-zaremba, ratik21 and surbhit14 February 1, 2022 13:24

ratik21 reviewed Feb 1, 2022

View reviewed changes

packages/runtime/src/lib/itxn.ts Outdated Show resolved Hide resolved

packages/runtime/src/lib/itxn.ts Outdated Show resolved Hide resolved

packages/runtime/test/integration/rekey-inner-tx.ts Outdated Show resolved Hide resolved

fix early review

3e28ed3

ratik21 approved these changes Feb 2, 2022

View reviewed changes

vuvoth added 2 commits February 2, 2022 22:18

update CHANGELOG.md

04ac14a

update CHANGELOG.md

3702295

vuvoth merged commit 8a0ffae into develop Feb 2, 2022

vuvoth deleted the fixbug-fromAddress-is-alway-application-address branch February 2, 2022 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixbug from address is alway application address when use inner Tx. #569

Fixbug from address is alway application address when use inner Tx. #569

vuvoth commented Feb 1, 2022

ratik21 left a comment

Fixbug from address is alway application address when use inner Tx. #569

Fixbug from address is alway application address when use inner Tx. #569

Conversation

vuvoth commented Feb 1, 2022

Proposed Changes

ratik21 left a comment

Choose a reason for hiding this comment