Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: close remainer to not remove auth account for rekeyed account #575

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Feb 8, 2022

Proposed Changes

  • Fixbug not throw error when closeRemainderTo equal sender
  • Fixbug not remove auth/spend address when close account
  • Add test cases for both case above.

@robert-zaremba robert-zaremba changed the title Fixbug close remainer to not remove auth account for rekeyed account Fix: close remainer to not remove auth account for rekeyed account Feb 8, 2022
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reduce copy-paste

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thanks!

@vuvoth vuvoth merged commit 3b137cf into develop Feb 9, 2022
@vuvoth vuvoth deleted the fixbug-closeRemainerTo-not-remove-auth-account-for-rekeyed-account branch February 9, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants