Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle sdk transaction in runtime #601

Merged
merged 23 commits into from
Mar 1, 2022
Merged

feat: handle sdk transaction in runtime #601

merged 23 commits into from
Mar 1, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Feb 24, 2022 •
edited
Loading

Proposed Changes

  • support execute asa deploy, app deploy, transfer algo (and more...) in sdk tx.
  • Move convert EncTx to ExecParams from itxn.ts to ixn.ts.
  • Convert appl transaction to ExecParams(DeployApp).
  • Fix: Decimals field should default 0 if we undefined it.
  • Fix: metadatahash(ASA Deploy) should convert back to string when we convert EncTx to ExecParams.
  • Test for those cases.

Please review it. Thank you <3

@vuvoth vuvoth marked this pull request as ready for review February 24, 2022 18:17
ratik21
ratik21 reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@ratik21 ratik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding comprehensive tests. We also need:

  • changelog update
  • docs update

@vuvoth vuvoth added the runtime label Feb 25, 2022
@vuvoth vuvoth requested a review from ratik21 February 28, 2022 00:01
sczembor
sczembor reviewed Feb 28, 2022
View reviewed changes
@vuvoth vuvoth changed the title Handle sdk transaction in runtime feat: handle sdk transaction in runtime Mar 1, 2022
robert-zaremba
robert-zaremba approved these changes Mar 1, 2022
View reviewed changes
robert-zaremba
robert-zaremba reviewed Mar 1, 2022
View reviewed changes
@vuvoth vuvoth merged commit fa15fb1 into develop Mar 1, 2022
@vuvoth vuvoth deleted the handle-sdk-transaction-in-runtime branch March 1, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@sczembor sczembor sczembor approved these changes

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@thdailong thdailong Awaiting requested review from thdailong

@ratik21 ratik21 Awaiting requested review from ratik21

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vuvoth @robert-zaremba @ratik21 @sczembor