Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support bsqrt and divw opcodes #605

Merged
merged 9 commits into from
Mar 7, 2022
Merged

feat: support bsqrt and divw opcodes #605

merged 9 commits into from
Mar 7, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Feb 28, 2022 •
edited
Loading

Proposed Changes

  • Add bsqrt and divw opcodes (Check packages/runtime/src/interpreter/opcode-list.ts)
  • Uint test for individual opcode(Check packages/runtime/test/src/interpreter/opcode-list.ts)
  • Modify parser to support both opcode.

Ref:

  • Link to opcodes docs here

TODO:

  • update Changelog after review.

Please review it! Thanks!

@vuvoth vuvoth added the runtime label Feb 28, 2022
@vuvoth vuvoth merged commit d150f4d into develop Mar 7, 2022
@vuvoth vuvoth deleted the add-bsqrt-and-divw branch March 7, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@thdailong thdailong thdailong approved these changes

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@sczembor sczembor Awaiting requested review from sczembor

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuvoth @robert-zaremba @thdailong