Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2c call support #611

Merged
merged 27 commits into from
Mar 24, 2022
Merged

C2c call support #611

merged 27 commits into from
Mar 24, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Mar 3, 2022

Proposed Changes

  • Support c2c call
  • Only allow CallApp action(not support DeployApp, UpdateApp... for now).

Notes

The main point need to note on my PR is if one appl inner transaction failed. The context(ctx) will not apply any changed
It's mean if appl A->B->C. and transaction B->C failed. we will roll back to the state before we call.

TODO:

  • Fix can't use TypeNum for teal v6(keyreg and appl)
  • Implement and add missing test for ITxna opcode.
  • Inner tx only can call to app implement in teal v6
  • Implement and test call app
  • NoOp with other appl type transaction. Only allow NoOpt(AppCall)
  • Update documents and changelog

NOTES

@vuvoth vuvoth changed the base branch from master to develop March 3, 2022 17:56
@vuvoth vuvoth marked this pull request as ready for review March 9, 2022 15:13
@vuvoth vuvoth added the runtime label Mar 9, 2022
@vuvoth vuvoth requested a review from ratik21 March 22, 2022 16:42
@vuvoth vuvoth merged commit f1fba81 into develop Mar 24, 2022
@vuvoth vuvoth deleted the c2c-call-support branch March 24, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants