Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add acct_params_get opcode #618

Merged
merged 8 commits into from
Mar 14, 2022
Merged

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Mar 10, 2022

Proposed Changes

  • Add AcctParamsGet to handle acct_params_get opcode(check opcode-list.ts)
  • Add acct_params_get to parser (parser.ts).
  • Create create for interpreter.getAcccount (check interpreter.ts). When create flag is false we will throws exception if account is not found else if create is true we will create new account and add this account to context.
  • Unit test for them

TODO

  • Update changelog.md after PR approval.

Please review my PR! Thank you a lot.

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre approving. Left few suggestions.

@vuvoth vuvoth added the runtime label Mar 11, 2022
@vuvoth vuvoth merged commit af24cc8 into develop Mar 14, 2022
@vuvoth vuvoth deleted the feat/add-acct-params_get-opcode branch March 14, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants