Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add itxn_next opcode #626

Merged
merged 16 commits into from
Mar 18, 2022
Merged

feat: add itxn_next opcode #626

merged 16 commits into from
Mar 18, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Mar 17, 2022

Proposed Changes

  • Add itxn_next opcode and unit test(both opcode unit test and parser unit test)
  • Add addInnerTransaction method(runtime/lib/itxn.ts) to create new inner transaction and add to inner tx groups.
  • Refactor pooled fee calculate(in itxn_begin, itxn_submit, itxn_next)

Potential followups

TODO:

  • Update docs and change logs.

Review list

  • itxn_next implement and unit test (happy cases and unhappy cases)
  • Calculate pooled transaction fees (itxn_next and itxn_begin is same, itxn_submit)
  • addInnerTransaction method (runtime/lib/itxn.ts).
  • Can create group inner tx by use itxn_next opcode
  • Typo or unclear message.
  • Documents and change logs.

Please review my PR! Thanks <3

@vuvoth vuvoth changed the title Feat/add itxn next opcode feat: add itxn_next opcode Mar 17, 2022
@vuvoth vuvoth added runtime enhancement New feature or request labels Mar 18, 2022
@vuvoth vuvoth mentioned this pull request Mar 18, 2022
6 tasks
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preapproving. Let's do the suggested renames.

Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

@vuvoth vuvoth merged commit 720d7ad into develop Mar 18, 2022
@vuvoth vuvoth deleted the feat/add-itxn_next-opcode branch March 18, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants