-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add itxn_next opcode #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preapproving. Let's do the suggested renames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: sczembor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
Co-authored-by: sczembor <[email protected]>
Proposed Changes
addInnerTransaction
method(runtime/lib/itxn.ts) to create new inner transaction and add to inner tx groups.Potential followups
TODO:
Review list
itxn_next
anditxn_begin
is same,itxn_submit
)addInnerTransaction
method (runtime/lib/itxn.ts).itxn_next
opcodePlease review my PR! Thanks <3