Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add gitxn, gitxna and gitxnas #628

Merged
merged 16 commits into from
Mar 28, 2022
Merged

feat:add gitxn, gitxna and gitxnas #628

merged 16 commits into from
Mar 28, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Mar 23, 2022 •
edited
Loading

Proposed Changes

  • Add gitxn, gitxna and gitxnas opcode
  • Test case for opcodes.

Note: I use inheritance to extends gitxn from gtxn and gitxna from gtxna. Please check code for more details.

Please review it! Thanks <3.

@vuvoth vuvoth changed the title Feat/add gitxn and gitxna feat:add gitxn and gitxna Mar 23, 2022
@vuvoth vuvoth added enhancement New feature or request runtime labels Mar 23, 2022
sczembor
sczembor approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

sczembor
sczembor approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuvoth vuvoth changed the title feat:add gitxn and gitxna feat:add gitxn, gitxna and gitxnas Mar 24, 2022
@vuvoth vuvoth requested a review from sczembor March 28, 2022 11:42
sczembor
sczembor approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, otherwise LGTM

@vuvoth vuvoth merged commit 46ad6b3 into develop Mar 28, 2022
@vuvoth vuvoth deleted the feat/add-gitxn-and-gitxna branch March 28, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@thdailong thdailong Awaiting requested review from thdailong

@ratik21 ratik21 Awaiting requested review from ratik21

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
enhancement New feature or request runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuvoth @sczembor