base64_decode opcode from TEALv7 #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczembor
requested review from
robert-zaremba and
vuvoth
and removed request for
robert-zaremba
vuvoth
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Thanks for your PR! I have few comments.
How about compute cost on this opcode?
Check list:
- Update opcode construction and logic.
- Opcode unit test.
- Add test for opcode on parser.
- Compute opcode cost. We use it for compute budget of transaction. Logic for compute budget(gas) in method
executeWithResultof classruntime/src/interpreter/Interpreter.ts.
ratik21
reviewed
Apr 13, 2022
vuvoth
reviewed
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #x
Proposed Changes
TODO
CHANGLELOG.MD