Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/extract opcode #666

Merged
merged 5 commits into from
May 4, 2022
Merged

Fix/extract opcode #666

merged 5 commits into from
May 4, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented May 2, 2022

Proposed Changes

  • Parameter in extract* opcode should be bigint

Test plan

  • Unit test.

@vuvoth vuvoth added runtime bug Something isn't working labels May 3, 2022
sczembor
sczembor approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the changeling in this case?

@vuvoth
Copy link
Contributor Author

vuvoth commented May 4, 2022

Should we update the changeling in this case?

Yes, I forgot it. Thanks

rmeena840
rmeena840 requested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Left comments.

@vuvoth vuvoth requested a review from rmeena840 May 4, 2022 08:54
@vuvoth vuvoth merged commit 7de34d5 into develop May 4, 2022
@vuvoth vuvoth deleted the fix/Extract16Uint-opcode branch May 4, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmeena840 rmeena840 rmeena840 approved these changes

@sczembor sczembor sczembor approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@thdailong thdailong Awaiting requested review from thdailong

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
bug Something isn't working runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuvoth @rmeena840 @sczembor