Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Can not issue itxn in clear program #667

Merged
merged 3 commits into from
May 4, 2022
Merged

fix/Can not issue itxn in clear program #667

merged 3 commits into from
May 4, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented May 3, 2022

Proposed Changes

  • Can not issue itxn in clear program
  • Unit test

Potential followups

@vuvoth vuvoth added the runtime label May 3, 2022
@vuvoth vuvoth changed the title Feat/Can not issue itxn in clear program fix/Can not issue itxn in clear program May 3, 2022
@vuvoth vuvoth added the bug Something isn't working label May 3, 2022
ratik21
ratik21 approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@ratik21 ratik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changelog update

@vuvoth vuvoth merged commit e09b76e into develop May 4, 2022
@vuvoth vuvoth deleted the fix/throw-error-when-call-inner-tx-in-clear-program branch May 4, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratik21 ratik21 ratik21 approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@thdailong thdailong Awaiting requested review from thdailong

@sczembor sczembor Awaiting requested review from sczembor

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
bug Something isn't working runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuvoth @ratik21