Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset sender #737

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Fix asset sender #737

merged 3 commits into from
Jul 13, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jul 12, 2022

Closes #729

Proposed Changes

  • Return zero for asset_sender.
  • Fix dao testcases.

TODO

  • update change log

Potential followups

@vuvoth vuvoth merged commit 694f30a into develop Jul 13, 2022
@vuvoth vuvoth deleted the fix-asset-sender branch July 13, 2022 14:40
@kashishkhullar
Copy link

Thank you for fixing this issue. I need this change to complete my unit testing. Will this be available in the next release?

@vuvoth
Copy link
Contributor Author

vuvoth commented Jul 15, 2022

Thank you for fixing this issue. I need this change to complete my unit testing. Will this be available in the next release?

Yes! and if you want to try it right now. You can build it from source!

@robert-zaremba
Copy link
Member

@kashishkhullar there are few ways how you can test the build from develop branch. I think the easiest one is to clone the repo and install algob in your system (eg, npm install -g) or run algob from the algob repo directly (this is what I'm using):

git clone https://github.com/scale-it/algo-builder.git
cd algo-builder
yarn build
cd <path to my project>
# you can add the line below as a script in your $PATH directory
<path to algo-builder>/packages/algob/node_modules/.bin/algob init mynewproject

Or use a local "dev" project in algob package, this is what we often use for testing.

cd algo-builder/packages/algob
./project-dev-script.sh create

We will prepare a guide for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Txn.asset_sender() gives different values in runtime and TestNet
3 participants