Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify missing condition in dao #746

Merged
merged 4 commits into from
Jul 20, 2022
Merged

verify missing condition in dao #746

merged 4 commits into from
Jul 20, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jul 20, 2022

Proposed Changes

  • Add rekey_to verify in deposit_vote_token
  • Add fee verifition in daoFundLsig.
  • Tests

TODO

  • update change log

Potential followups

@vuvoth vuvoth added bug Something isn't working examples labels Jul 20, 2022
robert-zaremba
robert-zaremba approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at it! Left few suggestions

@vuvoth vuvoth merged commit 40deed6 into develop Jul 20, 2022
@vuvoth vuvoth deleted the dao-update branch July 20, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@ratik21 ratik21 Awaiting requested review from ratik21

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@thdailong thdailong Awaiting requested review from thdailong

@sczembor sczembor Awaiting requested review from sczembor

Assignees
No one assigned
Labels
bug Something isn't working examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuvoth @robert-zaremba