New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `appendMultisigTransaction` to webmode #771

Merged

thdailong merged 12 commits into develop from web-algosigner-multisig

Aug 30, 2022

Contributor

thdailong commented Aug 22, 2022 •

edited

Loading

Closes #x

Proposed Changes

Add appendMultisigTransaction to webmode for appending signature to the multisig transaction

TODO

update change log

Potential followups

MAC added 2 commits

August 22, 2022 14:36


          Add appendSignMultisigTransaction to webmode

8be05a3


          update changelog

b58e081

thdailong requested review from robert-zaremba, rmeena840, sczembor, vuvoth and Megha-Dev-19

August 22, 2022 07:47


          update changelog

c52be1d

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

Contributor

sczembor left a comment

Thanks for the PR. Left few comments.

MAC and others added 3 commits

August 22, 2022 16:33


          Fix input grammar errors

c93a805


          Update CHANGELOG.md

0dedd3a

Co-authored-by: sczembor <[email protected]>


          Merge branch 'develop' into web-algosigner-multisig

03ee7e2

sczembor reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

thdailong and others added 4 commits

August 23, 2022 10:47


          Update CHANGELOG.md

ade4f3d

Co-authored-by: sczembor <[email protected]>


          Update packages/web/src/lib/web-mode.ts

3bbd721

Co-authored-by: sczembor <[email protected]>


          Update packages/web/src/lib/web-mode.ts

d8cc6b7

Co-authored-by: sczembor <[email protected]>


          Rename variable

1f4c310

sczembor reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/web/src/lib/web-mode.ts Outdated Show resolved Hide resolved

sczembor approved these changes

View reviewed changes

Contributor

sczembor left a comment

Pre-approval. Please check the comments before merging

thdailong and others added 2 commits

August 30, 2022 16:20


          Update packages/web/src/lib/web-mode.ts

18307a4

Co-authored-by: sczembor <[email protected]>


          Update CHANGELOG.md

5374ad6

Co-authored-by: sczembor <[email protected]>

thdailong merged commit 1a10475 into develop

thdailong deleted the web-algosigner-multisig branch

August 30, 2022 09:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sczembor sczembor approved these changes

robert-zaremba Awaiting requested review from robert-zaremba

rmeena840 Awaiting requested review from rmeena840

vuvoth Awaiting requested review from vuvoth

Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Labels

None yet