Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sha3_256 opcode to runtime #773

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Add sha3_256 opcode to runtime #773

merged 3 commits into from
Aug 30, 2022

Conversation

thdailong
Copy link
Contributor

@thdailong thdailong commented Aug 24, 2022 •
edited
Loading

Closes #x

Proposed Changes

  • Add sha3_256 opcode to runtime

TODO

  • update change log

Potential followups

vuvoth
vuvoth reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@vuvoth vuvoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I left a few comment.

@robert-zaremba
Copy link
Member

I've added a commit to introduce an abstract class for hash operations (to have less copy-paste code).

@thdailong thdailong merged commit 8ff782c into develop Aug 30, 2022
@thdailong thdailong deleted the add-sha3_256 branch August 30, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuvoth vuvoth vuvoth left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@rmeena840 rmeena840 Awaiting requested review from rmeena840

@sczembor sczembor Awaiting requested review from sczembor

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thdailong @robert-zaremba @vuvoth