Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max int fix #775

Merged
merged 6 commits into from
Sep 1, 2022
Merged

max int fix #775

merged 6 commits into from
Sep 1, 2022

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Aug 29, 2022 •
edited
Loading

Closes #768

Proposed Changes

  • Added test scenario for 'uint64' overflow
  • Added test for asa creation with total = 2^64-1

robert-zaremba
robert-zaremba reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test of constructing ASA with total=2^64-1

robert-zaremba
robert-zaremba approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sczembor sczembor merged commit 359a9a2 into develop Sep 1, 2022
@sczembor sczembor deleted the issue_768 branch September 1, 2022 10:38
@robert-zaremba robert-zaremba mentioned this pull request Sep 19, 2022
Closed
@robert-zaremba robert-zaremba changed the title Issue 768 Issue 768: max int fix Sep 19, 2022
@robert-zaremba robert-zaremba changed the title Issue 768: max int fix max int fix Sep 19, 2022
@robert-zaremba robert-zaremba mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuvoth vuvoth vuvoth left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sczembor @robert-zaremba @vuvoth