New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opcode ed25519verify_bare #776

Merged

thdailong merged 6 commits into develop from opcode-ed25519verify

Sep 6, 2022

Contributor

thdailong commented Aug 31, 2022 •

edited

Loading

Closes #x

Proposed Changes

Add opcode ed25519verify_bare
opcode ed25519verify_bare use the same test as opcode ed25519verrify

TODO

update change log

Potential followups


          Add opcode ed25519verify_bare

1aadf46

thdailong requested review from robert-zaremba, rmeena840, sczembor, vuvoth and Megha-Dev-19

August 31, 2022 16:21

MAC added 2 commits

August 31, 2022 23:24


          update changelog and parser

d7af5fa


          update changelog

7f3b3c4

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

Contributor

sczembor left a comment

Thanks for the PR. Could you please make sure that the tests scenarios that we are using are exactly the same as in go-algorand implementation. This is the best way to ensure that our implementation is correct.

MAC added 2 commits

September 1, 2022 17:44


          update test from go-algorand

4b0017c


          update

c789c50

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Show resolved Hide resolved


          Update capital word

45399ad

thdailong requested a review from sczembor

September 5, 2022 08:09

sczembor approved these changes

View reviewed changes

thdailong merged commit 43b78de into develop

thdailong deleted the opcode-ed25519verify branch

September 6, 2022 14:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sczembor sczembor approved these changes

robert-zaremba Awaiting requested review from robert-zaremba

rmeena840 Awaiting requested review from rmeena840

vuvoth Awaiting requested review from vuvoth

Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Labels

None yet