New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opcode `json ref` #781

Merged

thdailong merged 8 commits into develop from opcode-json_ref

Sep 21, 2022

Contributor

thdailong commented Sep 8, 2022 •

edited

Loading

Closes #x

Proposed Changes

Add opcode json ref

TODO

update change log

Potential followups

MAC added 2 commits

September 9, 2022 00:32


          Add opcode json_ref

73c319c


          Update changelog

f32503b

thdailong requested review from robert-zaremba, vuvoth, sczembor, Megha-Dev-19 and rmeena840

September 8, 2022 17:37


          Update yarnlock

2ffc061

sczembor reviewed

View reviewed changes

packages/runtime/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/src/lib/parsing.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

Contributor

sczembor left a comment •

edited

Loading

Looks good. Let m know if we cover all the important test cases from go-algorand

sczembor reviewed

View reviewed changes

packages/runtime/test/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/src/lib/parsing.ts Show resolved Hide resolved

sczembor reviewed

View reviewed changes

packages/runtime/src/interpreter/opcode-list.ts Outdated Show resolved Hide resolved

MAC added 2 commits

September 16, 2022 21:12


          Fix error

997e0c5


          Erase lines

c484ea9

robert-zaremba reviewed

View reviewed changes

packages/runtime/src/errors/errors-list.ts Outdated Show resolved Hide resolved

packages/runtime/src/errors/errors-list.ts Outdated Show resolved Hide resolved

packages/runtime/test/src/interpreter/opcode-list.ts Show resolved Hide resolved

MAC and others added 3 commits

September 20, 2022 23:36


          Add more test and fix grammar

413c54c


          Merge branch 'develop' into opcode-json_ref

93dab9b


          Fix error

7c610fb

sczembor approved these changes

View reviewed changes

Contributor

sczembor left a comment

LGTM

thdailong merged commit 4205d71 into develop

thdailong deleted the opcode-json_ref branch

September 21, 2022 16:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

robert-zaremba robert-zaremba left review comments

sczembor sczembor approved these changes

vuvoth Awaiting requested review from vuvoth

Megha-Dev-19 Awaiting requested review from Megha-Dev-19

rmeena840 Awaiting requested review from rmeena840

Labels

None yet