Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: MultiSig support in executeTx of webmode #785

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Feature: MultiSig support in executeTx of webmode #785

merged 4 commits into from
Sep 15, 2022

Conversation

rmeena840
Copy link
Contributor

@rmeena840 rmeena840 commented Sep 13, 2022 •
edited
Loading

  • Able to get msig txn response from AlgoSigner.
  • Msig support added.
  • ExecParam for msig also working

Respone after signing from AlgoSigner:
Screenshot 2022-09-15 at 12 54 18 PM

@rmeena840 rmeena840 marked this pull request as ready for review September 13, 2022 09:16
@robert-zaremba
Copy link
Member

@thdailong , @sczembor could you handle the review please?

@rmeena840 rmeena840 requested a review from sczembor September 15, 2022 16:01
sczembor
sczembor reviewed Sep 15, 2022
View reviewed changes
sczembor
sczembor approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Before merging please add more details in the change log. Thanks for the PR

@rmeena840 rmeena840 merged commit 72798a9 into develop Sep 15, 2022
@rmeena840 rmeena840 deleted the multi-sig branch September 15, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba left review comments

@sczembor sczembor sczembor approved these changes

@thdailong thdailong Awaiting requested review from thdailong

@ratik21 ratik21 Awaiting requested review from ratik21

@vuvoth vuvoth Awaiting requested review from vuvoth

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmeena840 @robert-zaremba @sczembor