Fix htlc example #792
Merged
Fix htlc example #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megha-Dev-19
requested review from
robert-zaremba,
thdailong,
rmeena840,
sczembor and
vuvoth
sczembor
reviewed
Sep 27, 2022
sczembor
reviewed
Sep 27, 2022
|
We need to comment the failing txn, it was causing the error, after commenting it we need to build it else the same code runs as it is written in typescript |
sczembor
approved these changes
Sep 28, 2022
But there isn't any change which needs to be added in changeLog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to fail because of failed txn, commented it, added error throw, doesn't need update in changelog