Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support loadLogic for *.teal program and SCParam #795

Merged
merged 7 commits into from
Oct 3, 2022
Merged

Feature: Add support loadLogic for *.teal program and SCParam #795

merged 7 commits into from
Oct 3, 2022

Conversation

rmeena840
Copy link
Contributor

@rmeena840 rmeena840 commented Sep 28, 2022 •
edited
Loading

Currently, only teal in python can be compiled with smart contract params but was not possible to compile teal with smart contract params. I have now added support for this to compile teal file along with smart contract params.

This resolves: #662

@rmeena840
Copy link
Contributor Author

@sczembor @thdailong Please review the PR.

@thdailong
Copy link
Contributor

Could you provide some description about the task you are doing. I am a bit confused about you are gonna do

@rmeena840
Copy link
Contributor Author

Could you provide some description about the task you are doing. I am a bit confused about you are gonna do

Check description.

@rmeena840 rmeena840 requested a review from thdailong September 29, 2022 05:52
thdailong
thdailong reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you to put those 2 it into a describe under describe ("Logic Signature", that describe can be like Load logic for teal program

@rmeena840
Copy link
Contributor Author

I recommend you to put those 2 it into a describe under describe ("Logic Signature", that describe can be like Load logic for teal program

Done @thdailong

@rmeena840 rmeena840 requested a review from thdailong September 29, 2022 11:50
thdailong
thdailong reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I let misunderstand my idea. I would like to have the describe("Load logic for teal program") in the describe("Logic Signature")
Cause your crow funding app use logic signature

@rmeena840
Copy link
Contributor Author

Sorry I let misunderstand my idea. I would like to have the describe("Load logic for teal program") in the describe("Logic Signature") Cause your crow funding app use logic signature

Done @thdailong

@rmeena840 rmeena840 requested a review from thdailong October 1, 2022 07:44
thdailong
thdailong approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approving!
Now this one looks good to me but you also check my comment one more time

@rmeena840 rmeena840 merged commit 842f94c into develop Oct 3, 2022
@rmeena840 rmeena840 deleted the logic branch October 3, 2022 05:48
@rmeena840 rmeena840 linked an issue Oct 6, 2022 that may be closed by this pull request
Add support loadLogic for *.teal program and SCParams #662
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdailong thdailong thdailong approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@ratik21 ratik21 Awaiting requested review from ratik21

@sczembor sczembor Awaiting requested review from sczembor

@vuvoth vuvoth Awaiting requested review from vuvoth

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support loadLogic for *.teal program and SCParams
2 participants
@rmeena840 @thdailong