Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignedTransaction and multi signature guide #797

Merged
merged 16 commits into from
Oct 10, 2022
Merged

SignedTransaction and multi signature guide #797

merged 16 commits into from
Oct 10, 2022

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Sep 30, 2022 •
edited
Loading

Closes #x

Proposed Changes

  • Create signedTransaction guide for Runtime
  • Create multi signature guide for Runtime

TODO

  • update change log

@sczembor sczembor requested review from robert-zaremba and vuvoth and removed request for robert-zaremba September 30, 2022 18:06
Megha-Dev-19
Megha-Dev-19 reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few suggestions

thdailong
thdailong reviewed Oct 1, 2022
View reviewed changes
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but you also need to change the format code in the guide.md

rmeena840
rmeena840 reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

robert-zaremba
robert-zaremba approved these changes Oct 7, 2022
View reviewed changes
thdailong
thdailong approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve! But now this one is good to me!
Also there is conflict you need to fix

@sczembor sczembor merged commit 2a503a3 into develop Oct 10, 2022
@sczembor sczembor deleted the signedTx_guide branch October 10, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmeena840 rmeena840 rmeena840 left review comments

@Megha-Dev-19 Megha-Dev-19 Megha-Dev-19 left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@thdailong thdailong thdailong approved these changes

@vuvoth vuvoth Awaiting requested review from vuvoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sczembor @robert-zaremba @rmeena840 @thdailong @Megha-Dev-19