Added error checks in examples

[Megha-Dev-19]

No description provided.

[sczembor]

I don't think these errors has anything to do with the changes you've made

[Megha-Dev-19]

@sczembor the htlc-pyteal example script is working on my local but it is failing on CI. could you please confirm if it is failing on your local as well.?
Thanks

[sczembor]

there are some problems with formatting.

[Megha-Dev-19]

there are some problems with formatting.

yeah I checked the formatting, and it is right, the change is because we have another set of curly brackets (for try and catch) now which affected the whole function

[sczembor]

It looks good, however I think we should rethink it. Maybe it would be better to throw the error inside of deployer? I am not sure about creating more wrappers for deployer since the examples are supposed to show real use cases that user can just adopt in their projects.

[Megha-Dev-19]

It looks good, however I think we should rethink it. Maybe it would be better to throw the error inside of deployer? I am not sure about creating more wrappers for deployer since the examples are supposed to show real use cases that user can just adopt in their projects.

The better solution to this can be to directly throw the error in executeTx method, like I did with web package, then in the examples we only need to catch it in places where the Transaction is SUPPOSED TO FAIL, and all other places if it failed it will throw an error

[sczembor]

Approve. I left few comments. I am still not sure about the .catch.throw construction. Maybe we can achieve the same results with different approach. Lets discuss it tomorrow during the review