Update: Replace arrow function with normal function in unit test #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeena840
requested review from
robert-zaremba,
sczembor,
vuvoth,
Megha-Dev-19,
ratik21 and
thdailong
rmeena840
force-pushed
the
function
branch
2 times, most recently
from
2b5af2b to
f76ab16
Compare
|
Looks good. Lets update change log. I also think we should add description to our guide about tests. Lets explain the reason for that and add link to mocha documentation |
rmeena840
force-pushed
the
function
branch
2 times, most recently
from
313f5bd to
2dc987f
Compare
I have added this. @sczembor |
sczembor
reviewed
Oct 11, 2022
sczembor
reviewed
Oct 11, 2022
sczembor
approved these changes
Oct 11, 2022
Co-authored-by: sczembor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.