Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in infrastructure/README.md #810

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

PabloLION
Copy link
Contributor

simply fix typo.

@PabloLION PabloLION changed the title Update README.md fix typo in infrastructure/README.md Oct 12, 2022
@rmeena840 rmeena840 changed the base branch from master to develop October 14, 2022 03:43
@rmeena840 rmeena840 changed the base branch from develop to master October 14, 2022 03:43
Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to us!
Next time you should fix from the branch develop since develop is the branch we are working on.

@robert-zaremba robert-zaremba changed the base branch from master to develop October 14, 2022 18:00
@robert-zaremba
Copy link
Member

I've updated the merge and resolved the conflicts. Thanks @PabloLION for contribution.

We need to make the release finally.

@robert-zaremba robert-zaremba merged commit fa6a728 into scale-it:develop Oct 14, 2022
@PabloLION
Copy link
Contributor Author

@thdailong I actually saw in in the guide but I forgot when I started the PR 😂 Thanks for fixing it.
@robert-zaremba I'm glad that I helped❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants