Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sendAndWait and waitForConfirmation methods #811

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Update sendAndWait and waitForConfirmation methods #811

merged 5 commits into from
Oct 18, 2022

Conversation

Megha-Dev-19
Copy link
Contributor

Updated return type of waitForConfirmation and sendAndWait in algob and web packages to make it compatible with executeTx

sczembor
sczembor requested changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the function descriptions about the return type. I also think we should add a simple unit test for all the updated functions if the testing mock is available

sczembor
sczembor requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some missing descriptions

@Megha-Dev-19 Megha-Dev-19 requested a review from sczembor October 17, 2022 09:31
sczembor
sczembor approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Check the comment before merging

@Megha-Dev-19 Megha-Dev-19 merged commit b99006b into develop Oct 18, 2022
@Megha-Dev-19 Megha-Dev-19 deleted the methods branch October 18, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmeena840 rmeena840 rmeena840 approved these changes

@sczembor sczembor sczembor approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@vuvoth vuvoth Awaiting requested review from vuvoth

@ratik21 ratik21 Awaiting requested review from ratik21

@thdailong thdailong Awaiting requested review from thdailong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Megha-Dev-19 @rmeena840 @sczembor