Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation for block opcode #816

Merged
merged 28 commits into from
Nov 2, 2022
Merged

implementation for block opcode #816

merged 28 commits into from
Nov 2, 2022

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Oct 19, 2022 •
edited
Loading

Closes #x

Proposed Changes

  • add support for block opcode in runtime
  • test scenario
  • add Blocks to runtime

TODO

  • opcode test scenario
  • block opcode implementation
  • function descriptions
  • add Blocks to runtime
  • test for runtime new methods
  • update changelog

Potential followups

@sczembor sczembor marked this pull request as ready for review October 27, 2022 17:13
@sczembor sczembor changed the title draft implementation for block opcode implementation for block opcode Oct 27, 2022
rmeena840
rmeena840 requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review.

@sczembor sczembor requested a review from rmeena840 October 27, 2022 22:14
rmeena840
rmeena840 reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

rmeena840
rmeena840 reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

rmeena840
rmeena840 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approve. Before:

  • Looks at comments
  • Update the changelog.

@sczembor sczembor merged commit 132db42 into develop Nov 2, 2022
@sczembor sczembor deleted the block_opcode branch November 2, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmeena840 rmeena840 rmeena840 approved these changes

@vuvoth vuvoth Awaiting requested review from vuvoth

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19

@thdailong thdailong Awaiting requested review from thdailong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sczembor @rmeena840