Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Create algob.config.ts for typescript project. #817

Merged
merged 7 commits into from
Oct 25, 2022
Merged

Conversation

rmeena840
Copy link
Contributor

@rmeena840 rmeena840 commented Oct 20, 2022

Added support for to generate the algob.config.ts file generation via algob (yarn run algob . --typescript) and read the algob.config.ts` file, if present in root directory.

Copy link
Contributor

@thdailong thdailong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you try to run project with algob.config.ts yet?

Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

@rmeena840
Copy link
Contributor Author

Have you try to run project with algob.config.ts yet?

Yes. It works well and unit tests are also passing.

@rmeena840
Copy link
Contributor Author

@thdailong @sczembor Ready for another review.

@rmeena840 rmeena840 requested a review from sczembor October 25, 2022 09:00
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@rmeena840 rmeena840 merged commit b0f4260 into develop Oct 25, 2022
@rmeena840 rmeena840 deleted the algob branch October 25, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants