Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secp256r1 curve support #831

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Secp256r1 curve support #831

merged 3 commits into from
Nov 3, 2022

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Nov 3, 2022

Closes #x

Proposed Changes

  • add support for secp256r1 to ecdsa_verify opcode.
  • add support for secp256r1 to ecdsa_PK_decompress opcode.
  • test scenario

TODO

  • update change log

Potential followups

@sczembor sczembor requested review from rmeena840, vuvoth and Megha-Dev-19 and removed request for rmeena840 November 3, 2022 09:48
Copy link
Contributor

@rmeena840 rmeena840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczembor sczembor merged commit 1407f88 into develop Nov 3, 2022
@sczembor sczembor deleted the secp256r1_curve branch November 3, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants