Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

fix(rich-select): find options in groups options #384

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Conversation

philibea
Copy link
Collaborator

@philibea philibea commented Jul 11, 2022

Summary

close #383

@philibea philibea added the bug Something isn't working label Jul 11, 2022
@philibea philibea self-assigned this Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #384 (a6e0b61) into main (f32bda1) will increase coverage by 0.89%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   94.04%   94.93%   +0.89%     
==========================================
  Files          21       21              
  Lines         235      237       +2     
  Branches       26       27       +1     
==========================================
+ Hits          221      225       +4     
+ Misses          9        7       -2     
  Partials        5        5              
Impacted Files Coverage Δ
src/components/RichSelectField/index.tsx 88.63% <60.00%> (+5.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32bda1...a6e0b61. Read the comment docs.

@philibea philibea force-pushed the fix-options-groups branch 2 times, most recently from 4570c34 to 3097a4c Compare July 11, 2022 10:53
@philibea philibea requested a review from QuiiBz July 11, 2022 12:03
@QuiiBz
Copy link
Contributor

QuiiBz commented Jul 11, 2022

Can we set a height for the container in both stories? That's kinda hard to see right now.

Screenshot 2022-07-11 at 14 04 21

Screenshot 2022-07-11 at 14 05 13

@philibea philibea force-pushed the fix-options-groups branch from c520852 to a1697bc Compare July 11, 2022 16:45
@philibea philibea enabled auto-merge (squash) July 11, 2022 16:45
@philibea philibea merged commit 385c08a into main Jul 11, 2022
@philibea philibea deleted the fix-options-groups branch July 11, 2022 16:46
scaleway-bot pushed a commit that referenced this pull request Jul 11, 2022
## [1.20.4](v1.20.3...v1.20.4) (2022-07-11)

### 📦 Chore

* **devdeps:** pin dependency @testing-library/react-hooks to 8.0.1 ([#385](#385)) ([17aeb1b](17aeb1b))
* **devdeps:** update actions/setup-node action to v3.4.0 ([#395](#395)) ([a0db091](a0db091))
* **devdeps:** update dependency @semantic-release/github to v8.0.5 ([#387](#387)) ([4f130de](4f130de))
* **devdeps:** update dependency @testing-library/dom to v8.16.0 ([#390](#390)) ([f32bda1](f32bda1))
* **devdeps:** update dependency eslint to v8.19.0 ([#391](#391)) ([cacbcf1](cacbcf1))
* **devdeps:** update jest monorepo to v28.1.2 ([#389](#389)) ([b649bab](b649bab))
* **devdeps:** update node.js to v18.5 ([#393](#393)) ([f168eb7](f168eb7))
* **devdeps:** update pnpm to v7.5.0 ([#394](#394)) ([6b4cf0d](6b4cf0d))

### 🐛 Bug Fixes

* **rich-select:** find options in groups options ([#384](#384)) ([385c08a](385c08a))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 1.20.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichSelectField Group Options doesn't display the right value
6 participants