From 76b070924db9597db62f434d225b3994e4023f88 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste WATENBERG Date: Wed, 30 Dec 2020 11:04:26 +0100 Subject: [PATCH 1/2] chips: fix missing semi colon leading to missing background when using the component and fix warning about ignored event listener --- src/lib/components/chips/Chips.component.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/components/chips/Chips.component.js b/src/lib/components/chips/Chips.component.js index e49fc4e42c..3b242d314b 100644 --- a/src/lib/components/chips/Chips.component.js +++ b/src/lib/components/chips/Chips.component.js @@ -77,8 +77,8 @@ const ChipsContainer = styled.div` ${props => { return css` ${props.variant === "warning" - ? `color: ${defaultTheme.blackLight}` - : `color: ${defaultTheme.white}`} + ? `color: ${defaultTheme.blackLight};` + : `color: ${defaultTheme.white};`} `; }} @@ -116,7 +116,7 @@ export const ChipsText = styled.span` display: inline-flex; justify-content: center; align-items: center; - padding: ${props => (props.icon || props.onRemove ? "5px" : "5px 10px")}; + padding: ${props => (props.icon || props.isRemovable ? "5px" : "5px 10px")}; `; const Chips = ({ @@ -144,7 +144,7 @@ const Chips = ({ {icon} )} - + {text} {onRemove && ( From 1741ea7385366a3210fceb536948c03a032447d3 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste WATENBERG Date: Wed, 30 Dec 2020 11:18:32 +0100 Subject: [PATCH 2/2] chips: update snapshot test to reflect unknown event handler property fix --- .../Chips.component.test.js.snap | 43 ++++++++----------- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/src/lib/components/chips/__snapshots__/Chips.component.test.js.snap b/src/lib/components/chips/__snapshots__/Chips.component.test.js.snap index 563f10969c..1c7dc6b0f5 100644 --- a/src/lib/components/chips/__snapshots__/Chips.component.test.js.snap +++ b/src/lib/components/chips/__snapshots__/Chips.component.test.js.snap @@ -10,7 +10,7 @@ exports[`Storyshots Chips Default 1`] = ` Basic Chip
@@ -74,7 +74,7 @@ exports[`Storyshots Chips Default 1`] = `
@@ -93,7 +93,7 @@ exports[`Storyshots Chips Default 1`] = `
@@ -112,7 +112,7 @@ exports[`Storyshots Chips Default 1`] = `
@@ -136,7 +136,7 @@ exports[`Storyshots Chips Default 1`] = ` Deletable Chip
Deletable @@ -185,7 +184,7 @@ exports[`Storyshots Chips Default 1`] = `
Deletable @@ -234,7 +232,7 @@ exports[`Storyshots Chips Default 1`] = `
Deletable @@ -283,7 +280,7 @@ exports[`Storyshots Chips Default 1`] = `
Deletable @@ -337,7 +333,7 @@ exports[`Storyshots Chips Default 1`] = ` Different sizes
Smaller @@ -386,7 +381,7 @@ exports[`Storyshots Chips Default 1`] = `
Small @@ -435,7 +429,7 @@ exports[`Storyshots Chips Default 1`] = `
Base @@ -484,7 +477,7 @@ exports[`Storyshots Chips Default 1`] = `
Large @@ -533,7 +525,7 @@ exports[`Storyshots Chips Default 1`] = `
Larger