Add support for two-characters typing + overall improvements #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't find a way how to properly replace the contents of the screen when in copy mode :/. This would allow us to use this plugin in copy mode too. If someone knows how to do this correctly, please let me know. |
|
Thank you for this! I am also looking forward to making this work in copy mode. |
|
This would be awesome! I'm not using |
|
Sorry, I wasn't clear. I didn't mean that I was planning to fix this. But thanks for the heads-up in this case I might need to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
This PR is not ready yet. I'd like to make this behave pretty much like vim easymotion. So when you type in the first character, the preview will already update and then again once you enter the second character.
I also wanna make sure we can use this in copy mode. Currently, we can only use
tmux-jumpstarting from normal mode and not within copy mode.Btw, very good code! :) Even though I haven't worked with Ruby at all so far, after watching a short video about it, I was able to understand your code pretty quickly and could contribute to it!