Skip to content
This repository was archived by the owner on Nov 24, 2018. It is now read-only.

Full page screenshot #92

Closed
dmitrika opened this issue Jul 29, 2017 · 3 comments
Closed

Full page screenshot #92

dmitrika opened this issue Jul 29, 2017 · 3 comments

Comments

@dmitrika
Copy link

dmitrika commented Jul 29, 2017

Hey, thanks for the awesome tool. 🎉

One of the greates features so far in chrome is fullscreen screenshots. Before, we have to scroll and combine different parts of a page for visual regression.

So, I would like to implement somehow option, which will say chromless to take full page screenshot without scrollbar. Any thoughts so far? 🤔

If it's technically posiible, I think passing options to .screenshot() will be ok.

const screenshot = await chromeless
  .goto('https://google.com/')
  .screenshot({fullpage: true, scrollbar: false})

and save current defaults

screenshot({fullpage = false, scrollbar = true}) {
...
}
@dmitrika dmitrika changed the title Full screen screenshot Full page screenshot Jul 29, 2017
@joelgriffith
Copy link
Contributor

Could probably solve this once #41 is implemented

@mattcanty
Copy link

#41 done in #137?

Can't quite tell...

@atbentley
Copy link

atbentley commented Mar 13, 2018

@mattcanty That looks to be correct. The following is taking a screenshot of the whole page for me for chromeless 1.5.0:

let screenshot = await chromeless.screenshot('body');

@joelgriffith This could possibly be closed now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants