-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider not advocating using action from main
#7
Comments
FWIW the safest way is to pin commit hashes. Dependabot knows how to bump them for as long as they are tagged.. |
(And can add a comment with the tag name) |
@henryiii that's neat — I didn't know that. Do you have an example you can share that I can look at for reference? |
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment the
v0.1.0
docs advocate that users use the action frommain
and not from a specific tag.upload-nightly-action/README.md
Lines 10 to 17 in 80af44f
This seems like a security issue that should be avoided and that @webknjaz has discussed before for https://github.com/pypa/gh-action-pypi-publish.
A more secure option is to advocate that users use release tags and dependabot to check for updates to the GitHub Actions that they use and then consider from the PR if the update in the tag is something they are ready to accept. Example
.github/dependabot.yml
(taken from Scikit-HEP developer recommendations (thanks @henryiii!)):The text was updated successfully, but these errors were encountered: