From 878b2bc68c39205018cd4840c0911dfcd6ba2d52 Mon Sep 17 00:00:00 2001 From: Jim Pivarski Date: Mon, 4 Mar 2024 12:53:19 -0600 Subject: [PATCH 1/3] chore: keeping CONTRIBUTING.md up to date (take 1) --- CONTRIBUTING.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9e7749f025..aebcb99666 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,10 +22,8 @@ Please [make the pull request a draft](https://github.blog/2019-02-14-introducin ### Getting your pull request reviewed -Currently, we have three regular reviewers of pull requests: +Currently, we have one regular reviewer of pull requests: - * Angus Hollands ([agoose77](https://github.com/agoose77)) - * Ioana Ifrim ([ioanaif](https://github.com/ioanaif)) * Jim Pivarski ([jpivarski](https://github.com/jpivarski)) You can request a review from one of us or just comment in GitHub that you want a review and we'll see it. Only one review is required to be allowed to merge a pull request. We'll work with you to get it into shape. From 869802e383b12dd2241bbbb549389a7a597eed67 Mon Sep 17 00:00:00 2001 From: Manasvi Goyal Date: Wed, 6 Mar 2024 10:00:23 +0100 Subject: [PATCH 2/3] chore: add a section for unit tests --- CONTRIBUTING.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index aebcb99666..0372618bed 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -141,6 +141,26 @@ python -m pytest tests-cuda-kernels python -m pytest tests-cuda ``` +#### Unit tests for the kernels + +You can also run additional unit tests that have more test coverage for all the low-level kernels for even more detailed fine-grained testing. + +For Python Kernels: +```bash +python -m pytest -n auto awkward-cpp/tests-spec-explicit +``` + +For CPU Kernels: +```bash +python -m pytest -n auto awkward-cpp/tests-cpu-kernels-explicit +``` + +For CUDA Kernels +```bash +python -m pytest tests-cuda-kernels-explicit +``` + + ### Building wheels Sometimes it's convenient to build a wheel for the `awkward-cpp` package, so that subsequent re-installs do not require the package to be rebuilt. The `build` package can be used to do this, though care must be taken to specify the *current* Python interpreter in [pipx](https://pypa.github.io/pipx/): From a5ad8d5e1da40f2151d6cc64ad376c01d5c7b08b Mon Sep 17 00:00:00 2001 From: Jim Pivarski Date: Wed, 20 Mar 2024 14:21:38 -0500 Subject: [PATCH 3/3] include tcawlfield in the list of regular reviewers --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0372618bed..1062ae971b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,9 +22,10 @@ Please [make the pull request a draft](https://github.blog/2019-02-14-introducin ### Getting your pull request reviewed -Currently, we have one regular reviewer of pull requests: +Currently, we have two regular reviewers of pull requests: * Jim Pivarski ([jpivarski](https://github.com/jpivarski)) + * Topher Cawlfield ([tcawlfield](https://github.com/tcawlfield)) You can request a review from one of us or just comment in GitHub that you want a review and we'll see it. Only one review is required to be allowed to merge a pull request. We'll work with you to get it into shape.