Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt typeguard version 4.0 #391

Closed
alexander-held opened this issue Mar 21, 2023 · 0 comments · Fixed by #406
Closed

Adopt typeguard version 4.0 #391

alexander-held opened this issue Mar 21, 2023 · 0 comments · Fixed by #406

Comments

@alexander-held
Copy link
Member

alexander-held commented Mar 21, 2023 •
edited
Loading

The release of typeguard version 3.0 causes CI failures due to an issue that is presumably related to agronholm/typeguard#315. This can be avoided with the 4.0-dev branch of typeguard. Switching to that branch results in a few new things getting flagged, which presumably were not picked up in version 2.0. Those should be addressed to improve the typing for cabinetry.

update: 4.0.0 is now out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adopt typeguard version 4.0 scikit-hep/cabinetry
1 participant
@alexander-held