From 169f2bec2c329745ced3d60cfc62d91208be524f Mon Sep 17 00:00:00 2001 From: arthur-lin1027 <35580059+arthur-lin1027@users.noreply.github.com> Date: Tue, 2 May 2023 20:09:15 +0000 Subject: [PATCH 1/2] fixed small typo in PCovR class documentation --- src/skmatter/decomposition/_pcovr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/skmatter/decomposition/_pcovr.py b/src/skmatter/decomposition/_pcovr.py index c7feaa267..eea5759dd 100644 --- a/src/skmatter/decomposition/_pcovr.py +++ b/src/skmatter/decomposition/_pcovr.py @@ -51,7 +51,7 @@ class PCovR(_BasePCA, LinearModel): For all PCovR methods, it is strongly suggested that :math:`\mathbf{X}` and :math:`\mathbf{Y}` are centered and scaled to unit variance, otherwise the - results will change drastically near :math:`\alpha \to 0` and :math:`\alpha \to 0`. + results will change drastically near :math:`\alpha \to 0` and :math:`1-\alpha \to 0`. This can be done with the companion preprocessing classes, where >>> from skmatter.preprocessing import StandardFlexibleScaler as SFS From 09702467a4d773b133f0329f0716669461cc1b1c Mon Sep 17 00:00:00 2001 From: arthur-lin1027 <35580059+arthur-lin1027@users.noreply.github.com> Date: Tue, 2 May 2023 17:05:14 -0500 Subject: [PATCH 2/2] Update src/skmatter/decomposition/_pcovr.py Co-authored-by: Rose K. Cersonsky <47536110+rosecers@users.noreply.github.com> --- src/skmatter/decomposition/_pcovr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/skmatter/decomposition/_pcovr.py b/src/skmatter/decomposition/_pcovr.py index eea5759dd..a02e5eb1f 100644 --- a/src/skmatter/decomposition/_pcovr.py +++ b/src/skmatter/decomposition/_pcovr.py @@ -51,7 +51,7 @@ class PCovR(_BasePCA, LinearModel): For all PCovR methods, it is strongly suggested that :math:`\mathbf{X}` and :math:`\mathbf{Y}` are centered and scaled to unit variance, otherwise the - results will change drastically near :math:`\alpha \to 0` and :math:`1-\alpha \to 0`. + results will change drastically near :math:`\alpha \to 0` and :math:`\alpha \to 1`. This can be done with the companion preprocessing classes, where >>> from skmatter.preprocessing import StandardFlexibleScaler as SFS