Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathpol: Implement ! and & operators for path policy sequences #2356

Closed
sustrik opened this issue Jan 17, 2019 · 1 comment
Closed

pathpol: Implement ! and & operators for path policy sequences #2356

sustrik opened this issue Jan 17, 2019 · 1 comment
Labels
feature New feature or request i/needs investigation Issues/proposals that need to be confirmed/explored

Comments

@sustrik
Copy link
Contributor

sustrik commented Jan 17, 2019

These operators are missing. In theory these could be implemented using regexp lookaheads, however, lookaheads are not implemented in golang regexp package. The reason is that there are not trivially, if at all, implementable using simple FSMs. For more context look here: golang/go#18868 (comment)

That being said, it's not entirely clear whether the operators are needed. Some use cases can be implemented using ACLs. There's also stuff that's not doable, but it's rather obscure, e.g. "go through ISD 64 on the second hop but not through AS 64-42; at the same time we don't want to blacklist AS 64-42 in this policy".

@scrye scrye added feature New feature or request i/needs investigation Issues/proposals that need to be confirmed/explored labels Dec 23, 2019
@scrye scrye changed the title Implement ! and & operators for path policy sequences pathpol: Implement ! and & operators for path policy sequences Jan 7, 2021
@scrye scrye added the t/swe label Jan 7, 2021
@matzf matzf removed the t/swe label Oct 10, 2022
@jiceatscion
Copy link
Contributor

This has not seen any activity other than labeling since being filed. The description implies that the feature might not even be helpful. So, I think it's a case of YAGNI. Please reopen if you have a clear use case.

@jiceatscion jiceatscion closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request i/needs investigation Issues/proposals that need to be confirmed/explored
Projects
None yet
Development

No branches or pull requests

4 participants