-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pip-compile-multi
option --autoresolve
#106
Conversation
… requirements file, that references (directly or indirectly) all other files.
It seems that The issue with |
template/requirements/all.in
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about the purpose of this file? We should communicate that nobody should make an env from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that all.in
file should actually be generated from the list of files in the requirements
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
template/requirements/all.in
Outdated
# NO ENVIRONMENT SHOULD BE CREATED FROM THIS FILE. | ||
# | ||
# We want to use the --autoresolve option of pip-compile-multi to make sure we do not run into conflicts across multiple txt files. | ||
# This feature works only if the project has a single requirements file, that references (directly or indirectly) all other files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# This feature works only if the project has a single requirements file, that references (directly or indirectly) all other files. | |
# This feature works only if the project has a single requirements file that references (directly or indirectly) all other files. |
f.write( | ||
"# This feature works only if the project has a single requirements file that " | ||
"references (directly or indirectly) all other files.\n\n" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: This would be more readable with a single multiline string.
@jl-wynen this doesn't work with the So I think we need to go back to pinning the |
We use the
--autoresolve
option ofpip-compile-multi
to make sure we don't run into conflicts across multiple txt files.According to the docs:
So I added the
all.in
file.TBH, I don't really understand why this is needed, I thought the whole point of
pip-compile-multi
was to make sure that the versions were the same for all envs, but anyway.